Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for trained model to be fully allocated #145

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

pquentin
Copy link
Member

Unfortunately the Python client does not currently sleep between retries, which means the fix from #83 isn't currently enough to pass the tests added in elastic/elasticsearch-py#140. This change, however, fixes the problem in the meantime. Thanks @ezimuel for the pointer.

Copy link
Member

@picandocodigo picandocodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! This works for me and I will test if it also removes the need of the timeouts on the Ruby client.

@pquentin pquentin merged commit 16c3950 into main Oct 14, 2024
4 checks passed
@pquentin pquentin deleted the trained-model-timeouts branch October 14, 2024 15:12
@pquentin
Copy link
Member Author

Spoiler alert: it was enough yesterday, but is not enough today 😅 It may be due to the update trained model step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants